數組的一些事

數組在拼裝和顯示的時候若是，顯示層級太多，形成閱讀和當即的不便。

好的寫法  ，

$productsData 數組操做

public function forwardProductList($manufacturerProducts)
    {
        $response = array(
            'message'      => 'No manufacturer product found',
            'isSuccessful' => false,
            'data'         => array(),
        );

        $productsData = array();

        foreach($manufacturerProducts as $manufacturerProduct){
            $imageData = array();
            $productImages = $manufacturerProduct->getActiveImages();
            foreach($productImages as $image){
                $imageData[] = array(
                    'url'       => $this->assetHelper->getUrl($image->getImageLocation(), 'manufacturer_product'),
                    'imageId'   => $image->getManufacturerProductImageId(),
                    'isPrimary' => $image->getIsPrimary(),
                );
            }
            $productUnitsData = array();
            $productUnits = $manufacturerProduct->getActiveUnits();
            foreach($productUnits as $productUnit){
                $productUnitsData[] = array(
                    'combinationid' => $productUnit->getManufacturerProductUnitId(),
                    'sku'           => $productUnit->getSku(),
                    'originalPrice' => $productUnit->getPrice(),
                    'finalPrice'    => $productUnit->getDiscountedPrice(),
                    'discount'      => $productUnit->getDiscountPercentage(),
                    'inventory'     => $productUnit->getQuantity(),
                    'weight'        => $productUnit->getWeight(),
                    'height'        => $productUnit->getHeight(),
                    'length'        => $productUnit->getLength(),
                    'width'         => $productUnit->getWidth(),
                    'attributes'    => $productUnit->getCombinationString(),
                    'moq'           => $productUnit->getMoq(),
                    'name'          => '',
                );
            }

            $productsData[] = array(
                'name'        => $manufacturerProduct->getName(),
                'referenceno' => $manufacturerProduct->getReferenceNumber(),
                'description' => $manufacturerProduct->getDescription(),
                'datecreated' => $manufacturerProduct->getDateAdded(),
                'images'      => $imageData,
                'combination'  => $productUnitsData,
            );
        }

        if(count($productsData) > 0){
            $response['message'] = "API Endpoint is currently unavailable";
            try{
                $request = new FormRequest(
                    FormRequest::METHOD_POST, '/'.$this->configuration['routes']['create_products'], $this->configuration['baseurl']
                );
                $request->setFields($productsData);
                $buzzResponse = new Response();
                $client = new Curl();
                $client->setTimeout(self::API_TIMEOUT_SEC);
                $client->send($request, $buzzResponse);

                if ($buzzResponse->isSuccessful()) {
                    $content = json_decode($buzzResponse->getContent(), true);
                    $response['isSuccessful'] = true;
                    $response['message'] = "Product created";
                    $response['data'] = $content;
                }
            }
            catch(RequestException $e){
                $response['message'] = "API endpoint request has timeout";
            }
        }

        return $response;
    }

很差的寫法

public function forwardProductList($manufacturerProducts)
    {
        $response = array(
            'message'      => 'No manufacturer product found',
            'isSuccessful' => false,
            'data'         => array(),
        );

        $productsData = array();

        foreach($manufacturerProducts as $k => $manufacturerProduct){
            $productImages = $manufacturerProduct->getActiveImages();
            foreach($productImages as $image){
                $productsData[$k]['images'][] = array(
                    'url'       => $this->assetHelper->getUrl($image->getImageLocation(), 'manufacturer_product'),
                    'imageId'   => $image->getManufacturerProductImageId(),
                    'isPrimary' => $image->getIsPrimary(),
                );
            }
            $productUnitsData = array();
            $productUnits = $manufacturerProduct->getActiveUnits();
            foreach($productUnits as $productUnit){
                $productsData[$k]['combination'][] = array(
                    'combinationid' => $productUnit->getManufacturerProductUnitId(),
                    'sku'           => $productUnit->getSku(),
                    'originalPrice' => $productUnit->getPrice(),
                    'finalPrice'    => $productUnit->getDiscountedPrice(),
                    'discount'      => $productUnit->getDiscountPercentage(),
                    'inventory'     => $productUnit->getQuantity(),
                    'weight'        => $productUnit->getWeight(),
                    'height'        => $productUnit->getHeight(),
                    'length'        => $productUnit->getLength(),
                    'width'         => $productUnit->getWidth(),
                    'attributes'    => $productUnit->getCombinationString(),
                    'moq'           => $productUnit->getMoq(),
                    'name'          => '',
                );
            }
            $productsData[$k]['name'] = $manufacturerProduct->getName();
            $productsData[$k]['referenceno'] = $manufacturerProduct->getReferenceNumber();
            $productsData[$k]['description'] = $manufacturerProduct->getDescription();
            $productsData[$k]['datecreated'] = $manufacturerProduct->getDateAdded();

        }

        if(count($productsData) > 0){
            $response['message'] = "API Endpoint is currently unavailable";
            try{
                $request = new FormRequest(
                    FormRequest::METHOD_POST, '/'.$this->configuration['routes']['create_products'], $this->configuration['baseurl']
                );
                $request->setFields($productsData);
                $buzzResponse = new Response();
                $client = new Curl();
                $client->setTimeout(self::API_TIMEOUT_SEC);
                $client->send($request, $buzzResponse);

                if ($buzzResponse->isSuccessful()) {
                    $content = json_decode($buzzResponse->getContent(), true);
                    $response['isSuccessful'] = true;
                    $response['message'] = "Product created";
                    $response['data'] = $content;
                }
            }
            catch(RequestException $e){
                $response['message'] = "API endpoint request has timeout";
            }
        }

        return $response;
    }

先寫值較複雜的，再元素整合在一個數組中。元素不少，放在數組中操做比較好閱讀。